Dmitry Gashko

Results 15 comments of Dmitry Gashko

Hi, thank you for your response. Firstly email validation is definitly incorrect: ![image](https://user-images.githubusercontent.com/20650419/60755597-ad524080-9ffa-11e9-953d-ff6969ed70e1.png) But that error, strangely, i can reproduce only by using screen reader (ChromeVox in my case). https://drive.google.com/file/d/1iBq2spO8qWKCSlpGbXaqbS6LrwhGag3F/view?usp=sharing...

If you fix that, your solution will be the best of vanillaJS form validation!

@PeterDekkers yeah, removing data-micromodal-close is the solution sometimes, but I usually need that functionality too. mousedown - probably, but it should be tested on mobile and other touch devices too

BTW, this issue is not Chrome specific. Yes, if are focused in some field - probably chrome specific. I don't see this in Firefox and Safari. But, if you start...

https://github.com/ghosh/Micromodal/issues/287 https://github.com/ghosh/Micromodal/issues/216

@mrdarkside That's almost the same what I did :) Only one thing - your solution doesn't work on touch screens. Here's my approach: ```js (function initMicromodal() { document.body.addEventListener('mousedown', (e) =>...

That's JsDoc comment. I use it just to autocomplete and intellisense. ![image](https://user-images.githubusercontent.com/20650419/88362457-3a427600-cd85-11ea-85ef-0587900bc0f7.png) ![image](https://user-images.githubusercontent.com/20650419/88362371-f2bbea00-cd84-11ea-80bf-b84600fbe8f8.png) ![image](https://user-images.githubusercontent.com/20650419/88362568-a58c4800-cd85-11ea-9201-3571f0b22f94.png)

I use [Event delegation](https://javascript.info/event-delegation), so, you don't need to add/remove each time. I mean, I add that event to the body element, so it will be called each time you...

Ok, I don't like that function at all. Too complicated to do so simple thing. I would write so ( ```js /** @param {'enable'|'disable'} value */ scrollBehaviour(value) { if (!this.config.disableScroll)...