Dietrich Brunn

Sorry for being bit late to the discussion. I compared the results of `envelope(x, None, 'analytic')` with `envelope(x, 1, 'rms')` which IMHO should produce identical results. I obtained:  The...

I pondered about the implementation a little bit more and noticed: - In signal processing downsampling usually delivers more consistent results than a sliding square window. - The [implementation](https://github.com/scipy/scipy/blob/5e4a5e3785f79dd4e8930eed883da89958860db2/scipy/signal/_signaltools.py#L2390) of...

Your are exactly right, @yagizolmez : $e_a(t)$ and $e_{rms}(t)$ are clearly not equal. The docstring is ambiguous: The `'rms'` method could also be interpreted as sliding a window over $|a(t)|^2$...

Considering the aliasing: You are right @yagizolmez, in my example aliasing does not occur (but using e.g., 400 and 450 Hz would do the trick). To compare the two methods,...

Depending on the application, the way low-pass filters are characterized varies quite a bit and is often inconsistent across the literature. The parametrization of [cheby1()] adheres to the established conventions...

You PR looks in good shape to merge, imho :tada: The test failures seem unrelated—what you could try to do: Revert @lucascolley's change concerning the boost sub-module and rebase your...

The rendered version can be found [here](https://output.circle-artifacts.com/output/job/69db5a90-bb10-4754-9208-8440a00cd600/artifacts/0/html/reference/generated/scipy.signal.envelope.html). I am not sure what to make of the error message: ``` scipy/signal/_signaltools.py:2467: in def envelope(z: np.ndarray, bp_in: tuple[int | None, int |...

Thanks @lucascolley, for the prompt answer. It could have been that I asked this question before :sweat_smile: Unfortunately, `python dev.py lint` does not complain...

> Have you considered extending hilbert rather than adding a new function? I did, but I came to the conclusion that that would only lead to confusion: The [analytic signal](https://en.wikipedia.org/wiki/Analytic_signal#Complex_envelope/No)...

> One thing catched my eye. Under certain circumstances, this function must give the same result with `hilbert()`, ... Good catch, thank you. I found an edge case where the...