Diana Lease
Diana Lease
I am able to get around this issue by overriding `Transforms.deselect` with `Transforms.deselect = () => {};` Similar to what I assume @Morphexe & @sunesimonsen are doing. However, is there...
> @DianaLease would you have cycles to pick this one up, now that we have updated Concerto? Sure thing! To make sure I understand the issue - wherever we use...
@dselman @jeromesimeon Looking into this more, I'm not sure it's actually necessary to introduce dayjs the way the current `concerto-ui` code is implemented (a bit has changed since this issue...
@jeromesimeon The value of timestamp there is a number (`typeof Date.now() === "number"`). But if we wanted to make it a string to be consistent we could do `new Date().toISOString()`...
> For generating diagrams, we will be using https://github.com/projectstorm/react-diagrams? Hi @kanav-raina, this library looks nice! That being said, we are not tied to a certain library. Best to research &...
hi @Cronus1007 . The logic that handles drop for the contract editor is here: https://github.com/accordproject/web-components/blob/5c92ecbe046af74aabdeed8be2990c28cb5fd9c6/packages/ui-contract-editor/src/ContractEditor/index.js#L199 This function is passed to the `MarkdownEditor` as a prop where it gets called whenever...
I can reproduce, both in the repo mentioned in the original issue and in a brand new create-react-app environment. I have tried with ui-markdown-editor, ui-contract-editor, and ui-concerto, and each produce...
The last version that does not have this error is `@accordproject/[email protected]`. The error seems to have been introduced in `@accordproject/[email protected]` and has since been an issue in subsequent versions and...
Alright, I was having trouble following how the `concerto-core-react` and `concerto-ui-core` used to be updated, but now I see in the commit mentioned in my comment above, the `concerto-ui-core` dependency...
One last note before I leave this for the night. I think I see where @dselman was coming from with the differing versions - I read through another older issue...