Devvox93
Devvox93
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. --- *[DSCResources/MSFT_xIisModule/MSFT_xIisModule.psm1, line 161 at r1](https://reviewable.io:443/reviews/powershell/xwebadministration/308#-Ksd6Tes965v4GOKOH-9:-Ksd6Tes965v4GOKOH-A:bkfhe2i) ([raw file](https://github.com/powershell/xwebadministration/blob/fd75a7d2ec8c13187a5d0aefb0f7d04d0c31336d/DSCResources/MSFT_xIisModule/MSFT_xIisModule.psm1#L161)):* > ```PowerShell > Modules = $ModuleType > ScriptProcessor =...
I'm about to make bigger changes to IISModule (and other resources), so I have added a comment to Reviewable. I'd like this issue to be Done before I start. I...
Exactly. The changes the author meant to perform was changing "Module" to "Modules" (with an S), which fixes a bug. However, author also added a hardcoded ResourceType, which is kind...
With the UI defaulting to File (I didn't think about that), I suggest this PR to be approved, as it does fix the bug mentioned in issue #305 . The...
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. --- *[DSCResources/MSFT_xIisModule/MSFT_xIisModule.psm1, line 161 at r1](https://reviewable.io:443/reviews/powershell/xwebadministration/308#-Ksd6Tes965v4GOKOH-9:-KsrQFQG2NCxK0UEyQKW:bgk8s7x) ([raw file](https://github.com/powershell/xwebadministration/blob/fd75a7d2ec8c13187a5d0aefb0f7d04d0c31336d/DSCResources/MSFT_xIisModule/MSFT_xIisModule.psm1#L161)):* Previously, Devvox93 wrote… Why hardcoding this to File? I...
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved. --- *Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/xwebadministration/308)*
Pull request for this is reviewed and approved.
@johlju I actually meant PR #308. But seeing your latest comment there I will be implementing what I suggested. So no PR yet as I've been busy with other work,...
Thanks for taking this up @scottmckenzie. I've been crazy busy and it totally slipped my mind :/ Apologies to @johlju also
I second this. The extension knows where it clones the arm-ttk repo. With a source folder as parameter, a simple Powershell script could copy the contents of that folder to...