DeveloperRob

PHP's 'readonly' modifier treated as '@phan-read-only' despite differences in expected behaviour

1

**stack trace for a crash** N/A **Code snippets (or a link to an affected project, if possible) and config settings (if any) needed to reproduce the issue.** Running phan test.php...

Single word namespaces which are reserved words produce an error incorrectly

1

[PR 331](https://github.com/microsoft/tolerant-php-parser/pull/331) doesn't support PHP8 valid namespaces which are a single non-string token. For instance, while the first code block will work without issue on PHP8 (as `T_NAME_QUALIFIED` will be...

Redundant Condition Detection doesn't account for initial 'unset' state from `!isset($this->y)`

2

Code Snippet: https://3v4l.org/lEbfg (full code also provided at end of issue) Phan version used: 5.4.1 Observed behavior: ``` test.php:10 PhanRedundantCondition Redundant attempt to cast $this->y of type string to isset...

Null Coalesce Assignment on a protected property not treated as a potential write

1

When using `??=` to set a protected class property, it is not detected this will write to the property is it null (or unset) currently. If you change to `$this->x...

Batch processing won't retry failures in same way as non-batch requests get retried

2

When sending a single request (which includes the batch 'wrapper' request), if a number of different errors occur (including rate limiting), {{src/Task/Runner.php}} will by default retry the request following Google's...

Dynamic function calling from array key isn't detected

1

If you have a `foreach`, and within the loop you do a dynamic function call with the array key(s), that function call isn't tracked for the purpose of used code...

This is best explained by the demo, but if you have an array for which phan can not determine the types (e.g. decoded from a JSON string), the first operation...

Good Morning, The definition of \FacebookAds\Object\AbstractCrudObjects` is: ``` /** * @deprecated deprecate constructor with null and parent_id * @param string $id Optional (do not set for new objects) * @param...

**Is your feature request related to a problem? Please describe.** In one of our projects, we use the [facebook-php-business-sdk](https://github.com/facebook/facebook-php-business-sdk). They have added the `@deprecated` flag to a fairly core constructor...

Add a new utility which will register an autoloader that will load either 'Current' (for a user specified version) or 'Latest' as a namespace path

1

Will fix https://github.com/googleads/google-ads-php/issues/1065 Add a new utility which can register an autoloader that allows user code to specify `\Google\Ads\GoogleAds\Latest` to always use the latest API version, or `Google\Ads\GoogleAds\Current` to always...