Devanjan Banerjee

Results 5 comments of Devanjan Banerjee

Wasn't this feature already a part of flask appbuilder? This is the one feature which was overlooked while migrating to react views I believe?

> @Pegoku mind adding tests? > > Also say I am logged in, I change my password, does it automatically log me out where I would have to log in...

related issue to this already mentioned by @Pegoku: https://github.com/apache/superset/issues/36223 Flask appbuilder doesn't have any mentions of deprecating the /resetmypassword or the /resetpassword endpoints either

> I am blocking this to discuss if it's a good idea. This opens up user impersonation by admins right? Granted api already allows it but the question is should...

> The screenshot shows the password change for the **current user** . I think if we need this feature we need a proper password reset flow with all the necessary...