Jayraj Dulange comments

Results 43 comments of


                                            Jayraj Dulange

Input issues with `sunpy.physics.differential_rotation.solar_rotate_coordinate`

> The bug is straightforward to fix: it shouldn't specify `observer` for the final frame if the final frame doesn't use that attribute. Correct me if I'm wrong, but this...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

Since its a temporary fix which could be removed once #7172 is fixed, does this require a changelog?

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> I would like a feature changelog and a unit test to ensure that the warning is raised please. > > Can you also rename the pull request. On it...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

In my initial approach, I was tempted to utilize Python's built-in globals() function to monitor the active context managers. However, this method proved ineffective for tracking across multiple modules. As...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> The precommit check is also failing, if you can fix that too please. Done!

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

I was just wondering, now that we have a global context tracker, should all the remaining context managers be modified to include the enter and exit methods applied?

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> I don't see the use case? I don't have a particular use case in mind, but I was suggesting in general, as it can help in maintaining uniformity of...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> I spoke to the other maintainers and they suggested that instead of the class, we can create a custom decorator (e.g., @sunpycontextmanager) that handles the entry/exit code. It should...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

@nabobalis Sorry for the delay! I've got the decorator in place and even wrote a test for it. Dealing with both the decorator and context managers was a bit tricky,...

Adds a warn when using both assume_spherical_screen() and propagate_with_solar_surface() context managers with reproject_to()

> Can you update the branch and see if that fixes the tests. If not, then something is going on in this PR and we have to track that down....