David Friedman

Use custom storage container for hub storage rather than enderchest

1

Im concerned about using the enderChest in all cases. Maybe in a future change we can instead use a custom storage container. _Originally posted by @Derongan in https://github.com/MineInAbyss/MineInAbyss/pull/64#discussion_r554672732_

setEngineServiceProvider should either be made obsolete or public

3

Any test cases requiring the geary engine need to call this test method or implement something similar. This should be exposed. Additionally, the fact that using a manually constructed concrete...

Engines should provide a check for if an entity is present, at least in tests

2

I noticed in your code you do some hacky stuff by using Geary.getNextId to figure out if an entity has been removed. This is downright barbaric. It only makes sense...

There is no up to date documentation for relations on the wiki.

Add migrations for geary entities

2

In geary-1.0 we had the concept of migrating entities when the definition updated. This was put in place to prevent existing items breaking on an upgrade. (see https://github.com/MineInAbyss/geary-1.0/blob/ebcfaa4deed2f28c523db9384b16375282eac344/src/main/java/com/mineinabyss/geary/ecs/entity/migration/GearyEntityMigration.java#L11) Something to...

Make it easy to have isolated sections that attach to eachother

1

Right now its not easy to have two separate sets of connected sections. This is allowed easily in the code, but the config does not support it.