Derk Schooltink comments

Results 13 comments of


                                            Derk Schooltink

Toolbar hiding fragment

I've written my own implementation from a fork of your repository. I've also submitted the pullrequest. You can find the PQ here: https://github.com/lawloretienne/ImageGallery/pull/36

remove $id and $schema from referred JSON schemata

This also applies to the `patternProperties` property. This is allowed by this validator but according to OpenAPI spec it is not: ![image](https://user-images.githubusercontent.com/22047701/90026351-79deec80-dcb7-11ea-8da5-26bb91a4e425.png) For reference: https://swagger.io/docs/specification/data-models/keywords/

Implement role assumption in RDS IAM connections

> Looks great, I assume you've tested this already? I'm happy to merge this as is, I just don't really like that I have no way to automatically run tests...

Implement role assumption in RDS IAM connections

I don't know exactly what's wrong with the tests, but they seem to time out, unrelated to my changes. Could you check @Askir

Implement role assumption in RDS IAM connections

@Askir don't want to push you too much, but I would highly appreciate it if you have some time to check out the playwright tests :D

Implement role assumption in RDS IAM connections

LGTM 🚀 Feel free to merge

Implement role assumption in RDS IAM connections

@Askir please 🥺

Implement role assumption in RDS IAM connections

It's up to you as maintainer, but I'm already running this build and have tested it a bunch and works great! :) You could always separate creating the service test...

Bump all versions to mitigate vulnerabilities

@Nebula1213 if you could do a quick review, that would be much appreciated :)

Add optional requirement of specifying an external reference on an execution request

I was contemplating if we could leverage the description field for it as well. Using templates might be enough to steer people in the right direction (i.e. provide an external...