Moritz Heidkamp
Moritz Heidkamp
Hi everyone, sorry for the negligence about this library. I haven't been using it anymore pretty much after its initial release and was too busy with other projects to keep...
> In the meantime, if you use deps.edn you can just use the revision [f9e11c3](https://github.com/dm3/clojure.java-time/commit/f9e11c3f852c14adf579d5101e7e98ec198eb343) in your code Unfortunately not because that would also require `clojure.java-time` to have a `deps.edn`...
Heh yeah went ahead and did just that. See https://github.com/dm3/clojure.java-time/pull/85.
> Was this solved with the merged #480 ? Looks like it just needs documentation now? Nope, the respective changes for unix domain sockets support were reverted before merge. See...
FWIW, this patch looks good to me! I rebased it onto latest `master` and added a few test cases for it over here: https://github.com/bevuta/aleph/tree/server-aggregator
> * How does it interact with [[client] Don't close connections when HttpObjectAggregator is on the pipeline #483](https://github.com/clj-commons/aleph/pull/483), as they mentioned above? The discussion above where this PR is referenced...
> This should be covered by means of having the test cases, right? Note https://github.com/clj-commons/aleph/blob/master/test/aleph/http_test.clj#L29 Welp, maybe not: I am not able to consistently trigger the leak detector even when...
> The only thing that bother me a bit is the fact we don't have any tests with a pipeline containing `HttpObjectAggregator`. (only for the websocket) I added some in...
> Regarding TLS, an improvement would be to support `javax.net.ssl SSLContext` out of the box. @arnaudgeiser Seems like this should be doable via https://netty.io/4.1/api/io/netty/handler/ssl/JdkSslContext.html which one could then pass as...
@KingMob FYI: I'll resolve the conflicts (and squash where appropriate) once you've approved my latest changes!