Dennis Bonke
Dennis Bonke
> Is this correct? Also, isn't this an abi-bit? Don't see why it isn't correct, and the distinction between needs to be abi-bit and can go into the main header...
> Because this doesn't seem to match between Linux architectures Of course they don't, I guess I'll move them then.
I tried to remember that, but unfortunately couldn’t figure out why I made this change. It could well be that we deem this unneeded, but I just wanted to try...
I managed to trigger it during normal use, we should implement this ASAP.
> is that code copied from musl? It is, I believe I left a comment about it in the source code.
I've improved the attribution as requested, ready for another review.
Wasn't this fixed already?
Keep in mind that the `iconv` utility is also provided by `libiconv` as far as I’m aware, so we need to make sure to gate it in the iconv option...
I’m inclined to agree, especially considering `libiconv` is a known working and complete implementation, but posix unfortunately specifies this so we have to provide it. I don’t plan on switching...
So what is the status on this one? I'm lost on what the actual consensus is now, can we merge this or is there anything I need to do?