Nick L.

> The point of the test was to check that the hard-coded version number located in the library class matched the version number detected and written in the CDN file...

I thought the event was [`user_login`, not `login`](https://github.com/e107inc/e107/blob/31ea9bf7879d3acad35f5f730ee7c1d5ca324ff6/e107_handlers/user_model.php#L1806-L1806).

Huh, then what is `user_login`? ಠ_ಠ

My opinion is that you should be using [`e107::getUser()->getId()`](https://github.com/e107inc/e107/blob/90108eab3c8c7667d3a2560acf97f40dbe4fd3b3/e107_handlers/user_model.php#L153-L153) instead of the constant `USERID`. The logged in user ID can change during the execution of e107, so having a constant...

According to the Git history, that `DROP DATABASE` was added in [an attempt](https://github.com/e107inc/e107/commit/1bae45f824825f1b80f4ef243aad7c1fc15653ee#diff-19e3c84c1b3ce87245588ae6ee7791fe3b94c98a8f955ea3e89f9f5865144ca0R630) to fix https://github.com/e107inc/e107/issues/676. I agree with you that it is not a nice solution, so perhaps we...

Got some early feedback on the current state of this pull request: * The usage help (`/mv` with no arguments) doesn't show PerWorldInventory as an import source. * There's an...

I was able to progress more with this patch: ```diff diff --git a/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java b/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java index fa76d5c..2c606ac 100644 --- a/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java +++ b/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java @@ -173,6 +173,7 @@ class PwiImportHelper { PlayerProfile pwiPlayerProfile;...

Thank you for the intriguing and detailed feature requests, @oskarkk! I went through every suggestion and came up with this summary of my intentions: | # | Suggestion | Implement?...

Hello @oskarkk! I've made some tweaks to the proposed implementations based on this second round of feedback from you: | # | Suggestion | Accepted? | Rationale | |-----|-------------------------------------------------------------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| |...

@CaMer0n, we will continue to have [this test failure](https://github.com/e107inc/e107/actions/runs/4161957819/jobs/7200544438) due to the dependency on the Internet while running "unit" tests: ```php --------- 1) e_library_managerTest: Detection version consistency Test tests/unit/e_library_managerTest.php:testDetectionVersionConsistency No...