Mikhail Krivushin comments

Results 38 comments of


                                            Mikhail Krivushin

Allow extra keys ignored after dict merge

Honestly this is a moment when I don't know. What behaviour is right?

Valid url do not fit trafaret.URL

Hi! Can you check if this link works with this pr? https://github.com/Deepwalker/trafaret/pull/36

Valid url do not fit trafaret.URL

Actually I'm not sure about right behavior. It's can be that link is actually incorrect. Will need to reread rfc

Fill t.Enum variants from Python standard library enum.Enum instances

I think this is ok. Want to do PR?

Valid emails do not fit trafaret.Email

"context" has a cyrillic C. Check this PR https://github.com/Deepwalker/trafaret/pull/36

Valid emails do not fit trafaret.Email

BTW maybe it will be good thing to depend on https://github.com/JoshData/python-email-validator

Valid emails do not fit trafaret.Email

@LShostenko your opinion?

Error classification

I think it is good to have DataError subclasses, due it is how exceptions in python designed to be. And `code` property would be nice to have too. Like `RequiredError().code...

Error classification

Codes and exception hierarchy is good thing. Why not to have it? It will not hurt experience, but can provide more use cases of library. You can safely ignore hierarchy...

Error classification

Exact JSON schema is up to you, it will not be a part of trafaret. So I vote for exceptions codes and hierarchy. And probably we will need to modify...