Deanna Gelbart

Results 5 comments of Deanna Gelbart

Fix issues, add CIE XYBri support, add Initial PHPUnit tests and Travis support.

getDistanceLabFrom() is not a Euclidean distance since it uses abs() instead of squaring https://en.wikipedia.org/wiki/Color_difference#CIE76 Once I make the change the result seems to match http://colormine.org/delta-e-calculator (I only checked one color...

Allow any combination of simultaneous sounds

Here is another way to do it which doesn't have the side effect of very fast repeats if you hold down a key a little too long https://github.com/Externalizable/bongo.cat/pull/286/files

Bugfix to allow playing 2 different samples which map to the same value in KeyEnum

Oh, there is already a PR for this

Bugfix to allow playing 2 different samples which map to the same value in KeyEnum

I closed this because I thought it duplicated another open PR, but later looking at the diffs I saw I took a different approach (changing the pressed array to store...

Bugfix to allow playing 2 different samples which map to the same value in KeyEnum

Link to the other PR https://github.com/Externalizable/bongo.cat/pull/286/files