David Loiseaux
David Loiseaux
Same issue here on linux (julia v1.6.1). ``` (@v1.6) pkg> update Updating registry at `~/.julia/registries/General` Updating git-repo `https://github.com/JuliaRegistries/General.git` No Changes to `~/.julia/environments/v1.6/Project.toml` No Changes to `~/.julia/environments/v1.6/Manifest.toml` (@v1.6) pkg> status Eirene...
I have this issue outside of Pluto, just using the terminal, the output of `plotbarcode_pjs` makes a small loading animation, and then stays blank. That's on linux, julia 1.6.2, and...
I'm not sure why the ci Tangential complex test fails on git, I cannot reproduce on my laptop & it doesn't fail on the other pipelines
@VincentRouvreau I've added your tests to the end of the test file, for the NaN and I had add some checks in the multi filtration file so that the behavior...
Changes since last time: - Finitely_critical_filtrations renamed to One_critical_filtration - Added a K critical filtration alongside previous one, for the moment defined as a vector of vector, but it may...
I also have a question : For multi-persistence it is often useful (e.g. to compute the eulerchar, the rank invariant) to project the filtration values on a grid. Thus I...
Thanks Marc for the review, - I've made a class for finitely critical filtrations, I had to do some "jardinage" because I couldn't get cython & c++ to cast a...
Changes since last update : - Merged upstream - changed `Filtration_value` io in simplextree to `const Filtration_value&`. - as far as I'm aware, `const stuff&` are dealt as const rvalues...
These changes should all be behind a ```if constexpr (Options::is_multiparameter)``` flag. I still need to fix this default value to use the `const Filtration_value&` to prevent copies; I can change...
After re-reading the code in the PR, I noticed that my previous statements were false : - The default value is always `{}` and only the python interface has different...