David Lowndes

Does this advice regarding ShouldProcess and ShouldContinue in "How to Request Confirmations - PowerShell" make sense to anyone?

3

The recommendation here to first call ShouldProcess and then (conditionally) call ShouldContinue seems wrong to me - leaving me totally confused about what ought to be straightforward. Given the code...

Code analysis dump

1

[ShortcircuitXT 23 Nov 2024.zip](https://github.com/user-attachments/files/17883127/ShortcircuitXT.23.Nov.2024.zip) @baconpaul Results from PVS-Studio analysis. Open the CSV in Excel using Data, From Text/CSV.

[Surge Code Analysis 23 Nov 2024.zip](https://github.com/user-attachments/files/17882724/Surge.Code.Analysis.23.Nov.2024.zip) @baconpaul Results from PVS-Studio analysis. Open the CSV in Excel using Data, From Text/CSV.

Fix `ValidateField` to correctly detect invalid characters as per issue #26044.

8

## Description As the code was, if there were no matching character, the inner while loop runs past the end of valid_chars until by chance it encounters a matching character...

Possible array overrun

2

## Bug report ### Describe the bug Here is a clear and concise description of what the problem is: In the following code: https://github.com/xbmc/xbmc/blob/3c88ff04edc95487569605b807ba59366ea4a35b/xbmc/cores/VideoPlayer/DVDCodecs/Overlay/contrib/cc_decoder.c?plain=1#L433C1-L436C1 the pos Presumably the test should...

Replace incorrect check of `result` with a direct validation of `sockets[1]` against `INVALID_SOCKET` after the `accept` call.

1

## Description The code was not checking the accept call success/failure correctly. Replace incorrect check of `result` with a direct validation of `sockets[1]` against `INVALID_SOCKET` after the `accept` call. ##...

Incorrect code in PLT_ProtocolInfo::ValidateField

4

## Bug report ### Describe the bug Here is a clear and concise description of what the problem is: The code in PLT_ProtocolInfo::ValidateField appears to be incorrect. https://github.com/xbmc/xbmc/blob/3c88ff04edc95487569605b807ba59366ea4a35b/lib/libUPnP/Platinum/Source/Core/PltProtocolInfo.cpp?plain=1#L236C1-L237C1 ## Expected...

Incorrect check of accept failure in socketpair()

3

## Bug report ### Describe the bug Here is a clear and concise description of what the problem is: This looks like a copy/paste issue. The code checks "result", which...

**Is your feature request related to a problem? Please describe!** Issue mentioned on discord ["Is this a known issue with Surge XT"](https://discord.com/channels/744319641211633774/1447686905847218328) This issue arises if you've MIDI learned an...