Lea Fairbanks comments

Results 7 comments of


                                            Lea Fairbanks

fix AbstractToken endOfLife initialization

Oh, I didn't update the tests, I'll get it tomorrow. My bad.

fix AbstractToken endOfLife initialization

I generally prefer to avoid those kinds of assumptions. To me, having multiple methods, one for an absolute time, and one for a relative time, is very explicit and behaves...

fix AbstractToken endOfLife initialization

I initially found the problem because I was trying to see if my tokens were expired and getting an incorrect value. The AbstractToken constructor was taking the absolute expiration time...

`rustup self uninstall` fails on Windows if a custom toolchain is installed

I went with your suggested approach, let me know what you think, thanks!

uninstalls toolchains prior to deleting the rustup home folder

sure thing, work has gotten a bit more stressful in the last couple weeks, I will try to do something this weekend

Remove win32console requirement in ruby 2.0.0 and higher

The CI check seems to fail because it's using an outdated version of bundler. See: https://github.com/bundler/bundler/pull/3559

uninstalls toolchains prior to deleting the rustup home folder

Sorry for the delay, I went ahead and added a test. Let me know if you like the approach!