Imants Horsts

Results 102 comments of Imants Horsts

I am not exactly sure what @romaninsh was thinking here, but I think it's about having `Persistence/REST` class in atk4/data repo, so we can simply set this persistence for model...

It's how it was before - BC way of doing things. But of course we should revise that and see if that's still good approach or need to move that...

This is important to think about and also this is not that simple to change and fix. That's because there can be anything in expression field. It can be subquery,...

Nested queries should be much more faster that using `having` which executes on full result-set. On other hand, in some cases (like mentioned above) using `having` is a solution. But...

Yes, this example is for simple `hasOne` case and standard title_field.

how about `$this->id` ? That should be the same as `$this->get($this->id_field)`.

I didn't get what improvement it is to remove these handy short-hand methods? They are not to complex to have I guess.

Yeah, ```addXxx``` should normally return newly created object (that's what I would normally expect from add method to return), so in addField case - return Field object. In `addFields(array)` case...

Well, I can live with that of course :) But having `addFields` in Reference is even more usable like @mkrecek234 said above. And if it's there, then why not in...

Maybe this should be fixed in Form class to not allow empty string values there? But more likely this should be fixed for all Models in Model_Table or maybe even...