Daniel Whyte

Results 48 comments of Daniel Whyte

In terms of the deleting associations, there are two ways we could go about it. The first is to simply do what we are already doing, which is updating the...

@nelsonic True, it was more the deletion of the actual association I was thinking of. For example, in CS if a venue wanted to remove a drink, but both the...

I was thinking about this, but hadn't had a chance to look into it yet. The same with `:entry_id`. I'll take a look into it and report back. The less...

We shouldn't need to write any more tests, the only lines that aren't covered are autogenerated Phoenix code

Yeah, that's unfortunately a known issue: https://github.com/parroty/excoveralls/issues/59

It is something to consider. I'll write up some of the pros and cons of each approach when answering #8

@RobStallion Yeah I'd assume that the problem is that the `schema_migrations` table is automatically created. But we can have full control over all tables being created, so we can either...

I've been having a look into the flow of how the Repo.all query is called: Repo.all -> Ecto.Repo.Queryable.all -> Ecto.Repo.Queryable.execute -> Ecto.Query.Planner.query (**Ecto.Query.Planner.plan**) -> adapter.execute (Ecto.Adapters.SQL.execute) -> adapter.execute! -> sql_call...

I think by the time it gets to that function, our Adapter `all` function has already been called, that's just where the sql it generates is actually executed

Moving this out of the February milestone for now until we come up with a good solution