Daniel Sturk

Results 12 comments of Daniel Sturk

Perhaps `ColorBackground` could include alpha, and this could completely replace `renderer.setClearColor()` and `renderer.setClearAlpha()`. A lot of passes right now have this messy save/restore pattern for the clearing stuff, eg. https://github.com/mrdoob/three.js/blob/dev/examples/js/postprocessing/RenderPass.js#L59

> I guess this closes #9163? Yes, thank you for linking that

In addition to `webgl_postprocessing_backgrounds.html` I tested it with all of -`webgl_envmap_*` -`webgl_materials_variations_standard.html` -`webgl_materials_standard.html` And it seems to work fine

> You used code #9163? What is different here? It's mostly a revive of #9163 (I didn't know that existed, #9163 has now been closed), *plus I integrated it into...

Thanks for all the feedback @WestLangley, I'll look into making these changes soon

> This PR was filed with little explanation. Is the objective to be able to blur backgrounds? If so, I am generally supportive of this. The primary object is to...

> In the mean time, this is what is rendered for me. Do you get the same result? That looks correct to me. A better demonstration would be turning the...

> > That looks correct to me > > Sorry, but there is no way that is correct. > > Compare with http://threejs.org/examples/webgl_materials_envmaps_hdr.html. It is correct. The other demo you...

@WestLangley Correct me if I'm mistaken, but this demo was never actually *broken* ![60761527-696e3400-a018-11e9-96ad-6ccd94b51d32](https://user-images.githubusercontent.com/2774286/61820672-787c2100-ae23-11e9-9d38-5a5889ded43f.png) The color only appeared off because the newly added 'hdr' box was checked by default. If...

@WestLangley Thanks for sticking around... I tried applying your 2 changes to `webgl_postprocessing_backgrounds.html`, and I agree, the demo does appear very similar to the master version. However, applying neither of...