DanielKauss

Results 14 comments of DanielKauss

Pretty sure the box uses the file `data/themes/default/lcd_21pink.png` for the colours, so just increasing the brightness of the digits may be enough of a fix. The only places where this...

> Wouldn't it better for reversed slices to be opt-in for each slice, rather than playing slices in reverse below the root? This would probably mean more infrastructure changes to...

> So this is a stopgap for better functionality that may come later? My concern is whether this could create difficulties in implementing future functionality in a backwards compatible way....

This seems like a pretty useful change, so no problem there. I gave it a quick look over and it seems mostly fine. The only thing I don't like is...

> Did you also test the rendering performance of the wave view with very large samples? It looks like you are caching the waveform in a QPixmap anyway though. Did...

> I have just tested the PR locally and noticed that resizing is very slow and sluggish after having loaded a sample that's 15 seconds long. I guess it will...

> Unfortunately for me it can go well into "several seconds" territory. I have recorded a resizing action here: Pretty strange. I have created a small patch to measure the...

> So the problem statement must be corrected to: Resizing the SlicerT window with large samples is laggy under Wayland. Or put differently: LMMS must ensure that it can render...

I'll leave this here in case someone else does a review. Using Qt layouts for the resizing is a waste of time, and would only complicate the code even further....

> I'll slack on the layout for now, but would like to see https://github.com/LMMS/lmms/pull/6992 (or atleast the bugfix) merged before this. The bugfix was already merged separately in #7174.