Daniel Doehring

Results 57 issues of Daniel Doehring

This adds the linearized Euler equations in 1D. This comes with 3 examples: The usual convergence test, a somewhat nontrivial example with walls and an elixir that illustrates the computation...

enhancement

The `equations` directory keeps filling up, what do you think about adding directories for e.g. `compressible_euler_equations` which contains the implementations of the respective dimensions?

discussion
low-priority
refactoring

Consider this example derived from the MHD rotor: ```julia using OrdinaryDiffEq using Trixi ############################################################################### # semidiscretization of the compressible ideal GLM-MHD equations equations = IdealGlmMhdEquations2D(1.4) """ initial_condition_rotor(x, t, equations::IdealGlmMhdEquations2D) The...

bug
parallelization

The IDP limiter looks like a powerful feature (at least given the amount of code involved) but is effectively not documented except for https://github.com/trixi-framework/Trixi.jl/blob/dfd632e69631ff4dbb42215966d4f7a546b92816/src/solvers/dgsem_tree/subcell_limiters.jl#L15-L57 Also in the elixirs, there is...

documentation

See https://github.com/trixi-framework/Trixi.jl/issues/1766

parallelization

For (scalar) hyperbolic PDEs $L^1$ is the [natural error norm](https://link.springer.com/chapter/10.1007/978-3-642-04048-1_6) around which the theory has evolved. I adapted the code for the $L^2$ errors such that now also $L^1$ errors...

enhancement

I noticed that a multithreaded execution (on Ubuntu 23.04, Julia 1.9.0, Intel i7-12800H) of e.g. the simple [1D advection example](https://github.com/trixi-framework/Trixi.jl/blob/main/examples/tree_1d_dgsem/elixir_advection_basic.jl) (without `SaveSolutionCallback` and `AnalysisCallback` causes many allocations compared to the...

performance
parallelization
low-priority

If we use the Julia built-in `@threads` instead of the [`Polyester.jl`](https://github.com/JuliaSIMD/Polyester.jl) by out-commenting the relevant section https://github.com/trixi-framework/Trixi.jl/blob/3d899bc3a301bdc40fc57afb95ea9e88ab10c459/src/auxiliary/auxiliary.jl#L227-L235 instead of https://github.com/trixi-framework/Trixi.jl/blob/3d899bc3a301bdc40fc57afb95ea9e88ab10c459/src/auxiliary/auxiliary.jl#L245-L247 there are allocations in several elixirs, see a [CI run...

performance
parallelization

To summarize the discussions in https://github.com/trixi-framework/Trixi.jl/pull/1629 I list some open points: - Outer datastructures for non-internal variables in `ViscousContainer`s: https://github.com/trixi-framework/Trixi.jl/blob/474410507181fa93cbe8201da4ade03311f09104/src/solvers/dgsem_tree/container_viscous_2d.jl#L3-L15 Usage of `Tuple` also for noninternal datastructures? - Different `reinitialize_containers!`...

discussion