Daniel Badura

Results 66 comments of Daniel Badura

I looked up how the extraction command is handling the ICU thing, and there, if i undestand it correctly, all message will extracted as ICU. The only exception is when...

I am still having problems even with these changes and try to figure it out with the Lokalise support. The `%LANG_ISO%` placeholder is not added to the filenames for example.

So after a longer discussion with the Lokalise support i got to this version of the LokaliseProvider: The Diff ```diff diff --git a/src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php b/src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php index b86d3924ff..b431d263bf 100644 --- a/src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php +++...

Yes i will try to look at it the next days @welcoMattic :)

So i rebased again and added a default value for the provider creation for the tests. That resolved most of the failing test. Now only my new tests are failing...

code style checks from fabbot seems unrelated 🤔

I would add some more tests the next days

Would need to kill some Mutants next 🗡️

I realised that the patch introduced alot of skipped mutants: This result is taken this PR and the action here Ref: https://github.com/maglnet/ComposerRequireChecker/runs/4844758145?check_suite_focus=true ``` PHPUnit version: 9.5.10 .: killed, M: escaped,...

Just pushed the increase of the config to create the result with the workflow.