David Dawson

Results 11 comments of David Dawson

@davydovanton we are looking at using the above approach, although we are unsure of who this would be used with something like `rom-rb` / `hanami-model`. As we currently only return...

After giving this some thought, I see 3 separate solutions if you are using the repository pattern: - You return the repository method e.g. `register(:index) { |_user| :exclude_draft }` -...

Just opened a PR: https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/pull/124

Possible workaround: ``` class Foo include ::Dry::Effects::Handler.Reader(:test) def call catch(:error) do unhandled_throw = nil with_test(:foobar) do throw :error rescue UncaughtThrowError => e unhandled_throw = [e.tag, e.value] end throw(*unhandled_throw) if unhandled_throw...

Any thoughts on this? as I would rather not use a rescue as it defeats the point of the efficiencies of using control flow over exceptions. A bit of context...

@flash-gordon It seems as though a similar problem was fixed in this repo: https://github.com/rmosolgo/graphql-ruby/pull/3333/files But as you suggest if may not be possible from these discussions: https://stackoverflow.com/questions/47833760/uncaughtthrowerror-raised-when-throw-is-called-in-a-fiber and https://www.reddit.com/r/ruby/comments/l431j4/interesting_throwcatch_behaviour_in_ruby/ I...

I have done some benchmarking, and it is not a disaster in terms of performance: https://gist.github.com/DangerDawson/9488598302a6d2ff9f2ea45912e5d4d7 Yielded these results: ``` Rehearsal ------------------------------------------------ Catch/Throw 0.217898 0.000054 0.217952 ( 0.218027) Raise/Rescue 0.738878...

We have just encountered this issue as well when cancelling an order. What should the behaviour be?

@bhanuone did you manage to solve this? I have hit exactly the same problem with the `tstzrange` type although I have loaded the `pg_range` extension

So the only way I managed to get this to work, was to monkey patch rom-sql with the types I needed which I stole from a later version of rom-sql....