Daimona

Results 34 comments of Daimona

> But isn't this exactly the same as [...] Sure, but mine was just a simplified example. You can replace `$val = 0` with `$val = rand()` (or anything else)...

> It isn't currently meant to, it just emits the issue suggesting that the phpdoc type be added (e.g. in case the library doesn't implement the method but applications using...

> Perhaps this was fixed with #4538? I've just tested this quickly, unfortunately it didn't help.

> Probably not long-term, but there aren't plans to change the behavior. Right now, it's a problem to tell if issues are actually the same, since there are different ast\Node...

@TysonAndre Thanks for looking into this. As you already found out, taint-check should no longer interfere with phan's caching of union types, since the plugin now caches union types as...

> @Daimona If you want multi-line control structures, the `Squiz` sniff may not be your best option. I suggest checking out the `PSR12.ControlStructures.ControlStructureSpacing` sniff or the `PEAR.ControlStructures.MultiLineCondition` sniffs instead. Thank...

> Is this still an issue with the latest release 5.4.2 Or with the very latest code from the default branch v5? Yes, I've just tested this on the latest...

Yup, I wanted to take a closer look but had some other things to do first :-) `WORD_REGEX` there is used for the parameter name, not the type. This one...

I thought this might've been fixable, but gave up upon seeing `UnionType::extractTypeParts`. It might still be fixable with the current regex-based parsing, but I feel like it would be too...

@gullevek Are you able to reproduce this using the [phan demo](https://phan.github.io/demo/)? The snippet you gave has a few syntax errors, so I tried to fix it a bit, but the...