Daan van Yperen
Daan van Yperen
Scope is limited to logic for generating classes so I'm for merging, assuming it doesn't cause issues for GWT. @junkdog?
*takes a look* .. this place is scary. :ghost: :ghost: :ghost: :ghost:
Sounds good! Recently added https://github.com/junkdog/artemis-odb/blob/master/artemis-core/artemis/src/test/java/com/artemis/EntityComponentLifecycleIntegrationTest.java to figure out how things work. Maybe take a look at the test names and see if we need to change any other behaviours?
The way we iterate definitely is verbose, but it is fast and avoids creating iterators or other objects. I personally favor less boiler plate myself and wouldn't mind a plugin...
Most of the API is not thread safe (Like Bags and component mappers) so can't be safely called inside a job. You'd have to feed it copies of the data...
Man you are an idea machine. Appreciate the posts. I'm reading it in backwards order. Do you have any usecases of ReactiveSystem? I'm looking for a reason why everyone should...
Did you manage to find a workaround?
Thanks for the PR! Sorry for letting it sit so long. I would probably use this feature myself. @junkdog what do you think? Sufficiently in scope? (Haven't reviewed the code...
Performance is probably not an issue, nobody should have aspect creation in a tight loop post init. Except maybe in serialization somewhere?
> I can fix the conflict. Would you rather see a merge or rebase? Leave it, the conflict is so minor we can fix it on merge.