Denis Zabavchik

Results 11 issues of Denis Zabavchik

In `wamp_session.ipp` it supposed to be `m_session_stop` promise used everywhere? Looks like copy paste issue? ``` inline boost::future wamp_session::stop() { ... if (!m_transport) { m_session_start.set_exception(no_transport_error()); return; } ... m_running =...

When client is on slow connection and large payload is scheduled PONG responses end up at the end of the send queue. Server socket schedules PONG timeout and closes the...

websocket
enhancement
needs-discussion

Two features and one problem fix: - Count negative events (crashes, connectivity issues, etc.). Do not attempt to ask for review if number of negative events exceeds threshold ``` void...

The following resource leaks were identified and fixed: 1. Proxy doesn't handle client (frontend) disconnects while establishing a backend session (UDS transport) -> UDS handle is leaked, Router retains session...

Finally found this leak that was haunting for 7+ years https://github.com/crossbario/crossbar/blob/0089c1ef6fbbb87fc7316088a91f1859fa84eeb0/crossbar/router/dealer.py#L1135-L1139 Zombie invocations remain in `_invocations_by_call` with references to callee, caller, authorization that will not be GC'd Testing changes that...

Although this has been tested extensively this PR is for evaluation/discussion only. This PR is superseding #2090 and #2091 Issues that it addresses for some setups (tested with single route...

There are just multiple instances of the same typo in RLink. Which is preventing loop detection when forwarding from working correctly. ``` this_forward = { 'session': details.caller, 'authid': details.caller_authrole,

`Broker.detach()` may publish `wamp.subscription.on_delete` about a wrong URI (one that still has subscribers) Local variable capture when `self._reactor.callLater(0, _publish, subscription)` used from a loop is passing last value of those...

Memory leaks fixed by #2098 unmasked smaller memory leaks in [dealer.py](https://github.com/crossbario/crossbar/blob/master/crossbar/router/dealer.py). Dealer.detach() iterates through invocations in flight where session is a caller or callee, performing inline `router.send` or `transport.send`. If...