Dmytro Shchehlov

ISP complicated or violated with wessberg/DI

4

Hey, guys, the library uses interface names as tokens and it complicates following to Interface Segregation Princinple. In example: ```ts interface IInfoLogger { info(message: string): void; } interface IWarnLogger {...

Some Architechture Concerns

3

Hey, @tshemsedinov Let's look on the sample code. ```js async ({ countryId }) => { const fields = ['cityId', 'name']; const where = { countryId }; const data = await...

DIP Violation

2

Hey, @vovaspace This line violates Dependcy Inversion Principle: https://github.com/vovaspace/brandi/blob/08a4748d7f6bcc301e4384fa0c291997af7bd5e3/docs/reference/dependency-modules.md?plain=1#L79 The ES-module with definition of `ApiService` class depends on infrastructure layer: your library `brandi` and on the module structue: `TOKENS`. Just...

Potentially dangerous code

2

https://github.com/metarhia/Example/blob/8a505455d984b6f34d6397bafcf0aeed0dec39e2/application/api/auth.2/signin.js#L7 The plain password must not be transferred to the 3rd-party code. This code must use node-embedded functions to get hash and compare it with the stored one. By the...

[Bug]: [vite] Internal server error: Cannot convert undefined or null to object

3

### Describe the bug Just Created Project doesn't start with build time error: ```shell [vite] Internal server error: Cannot convert undefined or null to object ``` ### Steps to Reproduce...