Dominik

Results 459 comments of Dominik

@PromoFaux I don't think so, when you go to any action page and click on "Use latest version", you get a yaml code suggestion like ![Screenshot_2022-07-24-15-19-30-48_3aea4af51f236e4932235fdada7d1643~2](https://user-images.githubusercontent.com/16748619/180648903-2e91625a-292e-4189-8feb-2117e5d3b661.jpg)

Latest seems to be the most recently released one, not necessarily in agreement with the largest version number. ![Screenshot_2022-07-24-15-28-47-05_3aea4af51f236e4932235fdada7d1643~2](https://user-images.githubusercontent.com/16748619/180649225-d4a7cde6-4089-49f2-9bcb-5fd926127b81.jpg)

I'm very much in favor of this change. Why are some things lines ``` php // Set mobile friendly viewport $viewPort = ''; ``` still there? Are they needed?

I have three comments after looking briefly at this: 1. We had one HTTP request (either download + code 200 or no download and some other response code) before. Now...

Rebased on latest `development`

The failed test is expected. The test tries to start FTL from `master` branch which complains about the invalid option `--supervised`

There is a POSIX recommendation that unknown options should be rejected as simply ignoring will likely cause application behavior different than you expect. `dnsmasq` behaves the same, even in it's...

I'm good with this given two things: 1. #3589 is updated and merged 2. This PR is updated (there are currently merge conflicts)

The web interface needs `root` every now and then to be able to (re)start the DNS/DHCP server `pihole-FTL` which is running as a system process and managed through `init.d/systemd`. The...

`setupVars.conf` is/was intentionally not imported because an import of an exported teleporter file from a *different Pi-hole could have lead to severe issues due to the incorrect `IPV{4,6}_ADDR`. Now that...