Hyunsoo Luke HA

Results 3 comments of Hyunsoo Luke HA

@ancientmooner Could you please check issue #237 ?

@juncgu Thanks for your suggestion. I have modified the code as the second option. Could you please take a look at this PR? @ancientmooner

> sorry for [#2074 (comment)](https://github.com/pytorch/torchtitan/pull/2074#discussion_r2587695418) > > I mean for that particular `eos_id` change in hf_transformers -- we should still remove others, could you add the changes back? @tianyu-l No...