Hugoren Martinako
Hugoren Martinako
> "All types" filter should have the "selected" status by default The radio buttons are generated through `form.collection_radio_buttons` helper. Currently there's no way to pass it a default value (i.e....
> Filter items font weight [should be regular (400)](https://www.figma.com/proto/3CNSXeFTMtUl2QdEUgLpEo/Decidim-PX?page-id=5604%3A308577&node-id=6017%3A317559&viewport=27994%2C-30081%2C0.57&scaling=min-zoom&starting-point-node-id=6209%3A222979&show-proto-sidebar=1&hide-ui=1) in unselected state :thinking: something has crept into. This branch does not introduce such problem. I'll keep digging in.
> The Follow button lost styles after click and shows number of followers. The text should be "Following" Same problem as mentioned [here](https://github.com/decidim/decidim/pull/9436#issuecomment-1206639485). > Responsive - Add text to action...
> Do you want to move these to the pending issues list or handle them before merging? Since this PR is "getting old", I rather prefer move all that stuff...
> Bottom margin should be 120px I'm gonna include that [here](https://github.com/decidim/decidim/pull/9436/files#diff-37dced5fada5cc29fe89f2c5d20983fa870e1e27d2b6b9b2003cd41316e6b8dcR17-R19) (different PR) in order to apply such condition to every single centered-layout. Is that ok @rober-gd ? You actually...
@ahukkanen I'm not being able to pass [this test](https://github.com/decidim/decidim/runs/7577337960?check_suite_focus=true). According the [proposed solution](https://dequeuniversity.com/rules/axe/4.4/aria-hidden-focus?application=axeAPI), one option is about set `display:none` as I did [here](https://github.com/decidim/decidim/blob/b0feeaac67db060712134db80c44a2531e66bed2/decidim-core/app/packs/stylesheets/decidim/_redesigned_accordion.scss) (multiple tries indeed). The page is using...
> The trigger element has to be a button or a link I turned it into a button, but the error persisted. What I did was about including into the...
Hmmm, my bad. Definitely, I saw green tests and re-request review button active and I went straight :sweat_smile: I'll solve as much as I can, otherwise I'll addressed in the...
@ahukkanen you may take a look again
I've been working on [a layout enhancement](https://github.com/decidim/decidim/pull/9755) that's gonna affect this PR and it's related with the pending point you noticed. Please, review/merge it asap to be able of updating...