Matteo Costantini

Negative page numbers return first page

1

Hi, I've noticed that `allow_overflow_page_number` options works only for pages greater that `total_pages` while querying with a negative page or page 0 still yield the first page. If `allow_overflow_page_number` is...

UnderscoreParameters behaviour with GET requests

6

Hi all! I've noticed that when calling an endpoint, the `UnderscoreParameters` applies the transformation only if the `Content-Type` header of the request is set to `application/vnd.api+json`, which makes sense in...

Add support for comma-separated filter values

14

Implements #235

UnderscoreParameters plug underscore filters only in params map and not in jsonapi_query assign.

1

Hi, I've noticed that using `UnderscoreParameters` acts inconsistently with filters. For example, the following request: ``` http://localhost/api/comments?filter[userId]=123 ``` corresponds, in the controller, to the following params: ``` %{"filters" => %{"user_id"...

Multiple values for same filter

2

The jsonapi spec states that multiple filter values can be combined in a comma-separated list. For example: ``` GET /comments?filter[post]=1,2 HTTP/1.1 ``` However, I noticed that the library returns a...

Fix Italian fiscal code generation

3

There were some bugs in the generation of the fiscal code that failed validity checks in our codebase: - The rule for the three characters in name and surname is:...