Corniel Nobel

As far as I understand the design choices made for JIL, it was always focussing on speed, not on extensibility. So, I hope my feature request is not seen as...

Extend Rule S2681 (put multiline blocks in braces) for additional patterns

5

I picked up the oldest open Issue (#194) and gave it a go. I first cleaned-up the existing code, and afterwards implemented the additional patterns.

New rule: Async methods with yield statements should have a decorated cancelation token

2

Fixes #6003 As proposed at the [community](https://community.sonarsource.com/t/c-find-missing-enumeratorcancellation-parameter), when having an async yielding method, the cancellation token should exist and be decorated. #6003 ``` C# async IAsyncEnumerable Yields([EnumeratorCancellation] CancellationToken token) {...

See: [RSPEC-2289](https://jira.sonarsource.com/browse/RSPEC-2289), and #365 ---------------- # Description The Obsolete attribute can be applied with or without arguments, but marking something Obsolete without including advice as to why it's obsolete or...

Implement S2225 - ToString should not return null - for VB.NET

10

Fixes #6112

RegEx evaluation should have a time out specified

23

See: [community.sonarsource.com](https://community.sonarsource.com/t/regex-evaluation-should-have-a-time-out-specified/40971), And RSPEC PR: https://github.com/SonarSource/rspec/pull/1188 # Description When using `System.Text.RegularExpressions` to process untrusted input, [pass a timeout](https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices). A malicious user can provide input to RegularExpressions causing a [Denial-of-Service attack](https://www.us-cert.gov/ncas/tips/ST04-015)....

Moved logic to a base class, and added VB.NET tests.

See [RSPEC 3898](https://sonarsource.github.io/rspec/#/rspec/S3898) # Description If you’re using a struct, it is likely because you’re interested in performance. But by failing to implement IEquatable you’re loosing performance when comparisons are...

Fix on FP 3925: Classes not having extra properties should not have to extend ISerializable interface

1

As reported (#3945), classed not having extra properties should not have extend the ISerialziable interface.

Numerals (numbers as written text) on longs.