Connor Stone, PhD
Connor Stone, PhD
Hi @fritzo thanks for the idea! That does seem easier!
Subclassing `BlockMassMatrix` is more elegant than what I did, but it still has the issue that I have to do it myself and so any updates to Pyro could break...
Hi @jjsutil That would be amazing if you could implement this! I agree, it's very feasible as a first contribution. Here is the line for the gaussian likelihood already implemented:...
@jjsutil Ah good question, yes AstroPhot has tons of unit tests here: https://github.com/Autostronomy/AstroPhot/tree/main/tests That's a good point and adding in a unit test would be really helpful! I imagine for...
Right, so section 2.2 in the paper goes over how a likelihood is computed under the assumption that the pixels have Gaussian noise, the goal here is to redo this...
You can certainly create 2D PSF models. I have wanted to make something like a diffraction spike model for a long time now, but I just don't really know what...
Hi @entaylor ! Yes I can just make a Moffat2D psf model and add it into the main code base. I'll let you know when it's ready (since I'm traveling,...
Hi @entaylor I have just merged in a new moffat2d psf model in PR #233 . You can see an example use of the model in the ModelZoo tutorial. I...
Hi @entaylor best of luck with your project! Let me know if you need anything else!
This is a fair point, and something that I have personally gone back and forth on a few times while developing the code. Ultimately, I went with log flux for...