Frank Anema
Frank Anema
I touched all the Python code and finished a first refactoring. It can be better, but it is functional now.
Good to hear you want to consider this PR. I follow regular PEP8, the default style guide for Python: https://www.python.org/dev/peps/pep-0008/ Is there a line width you want to stick to...
Does Travis also do code style reviews? Another project I work on uses Travis for testing and Stickler for automated code style review: https://stickler-ci.com/
Alright I finished cleaning up. The Travis test passed, so that's nice. I hope you guys like it, let me know if you have any further requests or suggestions.
Glad you like it. I agree on adding more tests, and also a good idea to add a pep8 check to Travis. But that's something for a new PR I...
You're right that the generated HTML/JS could be more efficient. Right now it is necessary for everything to render into one HTML file, so they can be embedded in Jupyter...
Hi @Norrius, thanks for taking on this project! Having smaller htmls is a good goal so I’ll be happy to review any PRs related to this. As I see it...
You're right that folium cannot dynamically update data, as in you cannot send data from Python to the already rendered map. Unless someone has a good idea for how to...
I'm not sure what you mean. Maybe you can share a link to a branch, gist of notebook?
Good call. I'll close the issue then.