Colin Kelley comments

Results 22 comments of


                                            Colin Kelley

Headers.from_native rdoc says it returns Hash<String, String> but actually it is Hash<Symbol, String>

Great, I'm happy to make a PR that changes the keys to strings including in the specs. I'm fine closing this ticket out as a duplicate of #168. But I...

Headers.from_native rdoc says it returns Hash<String, String> but actually it is Hash<Symbol, String>

PR is here: https://github.com/appsignal/rdkafka-ruby/pull/207

Issue #168/string keys for consumer message headers

@thijsc - I fixed that spec. https://github.com/appsignal/rdkafka-ruby/pull/207/commits/97e512243f05f9071c64d5c8502deff987551e72 - Also, I added a spec for `Headers` since that was missing: https://github.com/appsignal/rdkafka-ruby/pull/207/commits/0891e4d3d7c6db4d319a275613d378dcbf5c9f06 - And I was getting really nervous about breaking callers...

Issue #168/string keys for consumer message headers

@thijsc Here's a possible interim approach on Symbol-vs-String that is pretty close to `ActiveSupport::HashWithIndifferentAccess` but it's inline/dependency-free. It will tolerate a Symbol key (by converting it to String) but it...

Issue #168/string keys for consumer message headers

@thijsc Just following up to see if you have any thoughts on the above?

Headers.from_native rdoc says it returns Hash<String, String> but actually it is Hash<Symbol, String>

Resolved with #207 merge.

Issue #168/string keys for consumer message headers

@thijsc Will do.

Issue #168/string keys for consumer message headers

@thijsc The build here is green after the rebase. 👍

Headers.from_native rdoc says it returns Hash<String, String> but actually it is Hash<Symbol, String>

@thijsc Now that this PR is merged into master, can you please release a new version sometime soon that includes it?

Suggested API change

> Regarding your proposal, how does this work ``` Async.run do # (1) Is this an error? end ``` Haha, I was going to ask you the same thing! Is...