Cyril Cohen

Results 406 comments of Cyril Cohen

> rebuilding HB without the offending module. Would that be easy?

I'm sorry, I do not understand. CC @gares

I did not read the PR but one should ideally show that the type `angle` whatever its definition is a ring quotient of `R` by the ideal `2 * pi...

> > I did not read the PR but one should ideally show that the type `angle` whatever its definition is a ring quotient of `R` by the ideal `2pi`...

Be careful, you do not need to build `angle` using a quotient (maybe the arguments of complex numbers was actually the right one), but you can provide a quotient interface...

It could also be the definition of angle... sure

Great! But even if the CI does not seem to show a single failure, this change is not backward compatible, so I'm a little bit hesitant to approve. It could...

@maximedenes do you still intend to work on this and the related issue #93?