Mikel Blanchard

Results 186 comments of Mikel Blanchard

@Kielek @vishweshbankwar I think this is good to go but since it is touching a lot of the repo I would like another maintainer to approve before merging.

Hey @YanlingCui! The WCF instrumentation works with .NET Framework & .NET/Core clients. It also works for .NET Framework servers. Some examples in this folder: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/examples/wcf Previously when this work was...

For anyone looking to implement this see: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/833#issuecomment-1377730321

Do we need to add unit tests?

I just opened a new spec PR to try and get the ball moving: https://github.com/open-telemetry/semantic-conventions/pull/1339 I had another one open but it just went into a void 😢

Some updates on recent changes... * We added a top-level `RELEASENOTES.md` which is curated and may be more appropriate for NuGet: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md * We also have improved release process/automation to...

@Aaronontheweb Something in your report isn't adding up for me. The issue @julealgon reported is when calling [Host.CreateEmptyApplicationBuilder](https://github.com/julealgon/OpenTelemetry.UseOtlpExporterIssue/blob/204981d737394f290cb2ddc8567f923d0fe87ef8/OpenTelemetry.UseOtlpExporterIssue/Program.cs#L5) then environment variables are NOT automatically loaded. But you are calling `WebApplication.CreateBuilder`:...

Here's some code you can use to inspect things with debugger: ```csharp using Microsoft.Extensions.Options; using OpenTelemetry; // Same test can be performed using real vars on the system Environment.SetEnvironmentVariable("OTEL_EXPORTER_OTLP_ENDPOINT", "http://helloworld/");...

@trask So I got everything to work using opentelemetrybot: https://github.com/open-telemetry/opentelemetry-dotnet/pull/5662 The big challenge I faced is trying to test everything via forks is very heavy lifting. I had to create...

> we should rather look into generalizing solutions across repositories. Definitely agree with this in general. For this "use an app for granting permissions to automation" case though we may...