Christian Zaccaria

Results 32 comments of Christian Zaccaria

@kevin85421 Agreed, thank you!! I've just learned that jobs can run on the Head Pod without the need for Workers. - Closing PR.

Hi @slashpai, I was wondering what is the status of this PR? Is there more to be done on it? Very interested as this could potentially solve this 'High' CVE....

> > Do we have any plans to change the label name from `appwrapper.mcad.ibm.com` to something consistent with the group name, maybe `appwrapper.worload.codeflare.dev`? > > Yes, I agree it'll have...

> If I read this correctly, the latest push adds a label with the namespace of the wrapped resource itself rather than the appwrapper namespace. I am not sure I...

@astefanutti Hi Antonin, I'm wondering if you think updating the `quotaManagement.rbac.apiGroup` like this is correct? From `ibm.com` to `quota.codeflare.dev`. Thanks! https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/bbb6871a4d79d1364cd04504557d0f1c4c671844/test/kuttl-test-borrowing.yaml#L8

I attempted to not use completely the resourceName label but caused the e2e tests to fail. I believe it has to do with certain scenarios where the resourceName differs from...

> Hello @ChristianZaccaria , a lot of changes seems to be unrelated, or indirectly at least, to the original issue: ![image](https://private-user-images.githubusercontent.com/7559202/285513790-5ec0ab38-532a-4696-973b-d6ba0b887b67.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEwNzkwMTAsIm5iZiI6MTcwMTA3ODcxMCwicGF0aCI6Ii83NTU5MjAyLzI4NTUxMzc5MC01ZWMwYWIzOC01MzJhLTQ2OTYtOTczYi1kNmJhMGI4ODdiNjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQUlXTkpZQVg0Q1NWRUg1M0ElMkYyMDIzMTEyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyMzExMjdUMDk1MTUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmM2NTUwMmYzYThlZDc3OGY4MmFhMWU3MTNjOTI1ZDk1NDUwNjU3YTAxMGJlMTU2NmI3OWVmMTkzZWRkODM2MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UbxsDPn9rjuShIQ_v-nihi6lIrFQOfpbrXFP6FKCoi4) > > shouldn't these change be merged in another...

/retest Seems the CI is acting up. I'm pretty sure it has nothing to do with your changes.

Hey Mark, could you try change i.e., a comment or add a comment and push changes, just to trigger the CI again and see if it works. The `/retest` option...