Chris Loer

Results 9 comments of Chris Loer

Any updates on triage here? It'd be nice to get a fix into a patch release -- as is we risk hitting existing customers with a perf regression when they...

The workaround we're using is to reach into the map's private variables and explicitly clear `_serializedLayers` before we set the map's style, forcing a serialization every time (I believe getting...

Yeah, that looks like the fix I had in mind. I don't know if there are other style-update cases out there that would still be affected, but it would fix...

> @ChrisLoer any chance you might be able to look at this PR? It would help a lot I believe. I just spent about 20 minutes going through it, which...

> This is probably not worth optimizing further, especially with the assumption that symbol placement runs asynchronously in a separate thread, so it would not slow down rendering. Is that...

Yeah the problem here is that the collision boxes are based on the `collisionTextBox` that's generated on the worker thread at tile creation time (and thus only generated at integer...

https://github.com/mapbox/mapbox-gl-js/pull/4847 brings the size of the plugin down from 396KB to 273KB: not enough to bundle it in, but going in the right direction. If/when we [start using Web Assembly](https://github.com/mapbox/mapbox-gl-js/issues/4835#issuecomment-309117866),...

Yeah, looks like the problem is that when we calculate the label length for anchor-spacing purposes, we take the max of the "icon" and "text" length, and then multiply them...

> Is the valid workaround to reduce the actual size of the icon and set 'icon-size' to 1? Yup, that's a good workaround!