Chris Arnott
Chris Arnott
I've added a pull request. I haven't tested that it works, but it's the sort of way that I imagine adding extra Inspections. (The sbt plugin could enforce type safety...
Hi, I have seen your comment. I've been having a hard time running `make generate-component-docs`, but I have got a test. I'm unlikely to get any changes before next week,...
The build should be fixed now. I'll sort out docs and a test soon.
The code should all now be good. I have: * An old machine connected to the internet. * A new machine that's air gapped. I haven't been able to get...
Got the docs updated as well. Just need to fix the branch to have an email on the two commits that are missing one.
I've done a force push to my branch to fix the authors (so that the CLA check passes). There's no code diff since your approval. Let me know if there's...
I've updated this to take multiple strings. I initially looped through each value and called `warp::reply::with_header(key, value)`, but the test showed that the values were being overwritten (which surprised me...
@jorgehermo9 I've updated the PR to use `append` and `insert`. We're on http 0.2.9, so don't have `try_append` and `try_insert` and I didn't fancy doing a major version upgrade of...
@jszwedko thanks for the feedback. I've addressed it and this is hopefully good to go now!