Chris B
Chris B
currently generated a chem_annotated.yaml and a chem.yaml. chem.yaml looks fine but the chem_annotated.yaml does not store the comments under "notes" for the reactions.
This passes all tests and fixes the issue of not getting the coverage dependent parameters into the Cantera output file. I believe this needs to be merged before we can...
One other thing to note is the test for generating an output file with the ck2yaml parser behaves a little differently. If we do not specify all of the elements...
at least when I tried it, it does get written to the chemkin file like this: ``` ! Reaction index: Chemkin #1; RMG #1 ! Library reaction: Surface/CPOX_Pt/Deutschmann2006_adjusted ! Flux...
I am not sure if we have an issue for it, but the solution to this issue is we need to upgrade the cantera version we use to 2.5/2.6 and...
So far, the problem appears to be that the ReactionMechanismSimulator package in julia does not update with the main branch of the RMS github repo, despite it being specified in...
I tried a clean install using the developer instructions, with the modification to the rms install step: ``` julia -e 'using Pkg; Pkg.add(PackageSpec(name="ReactionMechanismSimulator",rev="main")); using ReactionMechanismSimulator;' ``` It worked fine when...
Just an update, I talked with @cfgoldsmith and @rwest about this. To summarize, we think that we should modify the rules and training themselves to account for reaction path degeneracy,...
I agree with Matt, It will take me a little bit but I can update the developer instructions to include setting up RMS independently, I have already done that successfully...
I tried generating katrin's model (see below) without the check that a surface site matches only a surface site in the template. I did that by commenting out [this](https://github.com/ReactionMechanismGenerator/RMG-Py/blob/a06bed3b19bb3f7a1c206c0b4502bde9631e42ac/rmgpy/data/kinetics/family.py#L2136) ```if```...