Christopher Molin
Christopher Molin
Hi @NotMyFault & @mawinter69 ! Sure thing, I could to the suggested changes. Should I at the same time also mark these as deprecated?
Is there a specific 'since' version that should be referenced instead of a date? Description of Deprecation; > @**deprecated** because the current version is at least Java 11, this method...
> `TODO`; automatic tooling will fill in the tag version it has been released in. Oh, very cool! Will update this. Thanks!
@wing328 really not sure why it is failing. The error indicates that the samples are not updated, but they are 🤔 Edit: nevermind, the /bin structure is unlike the /resources...
@Picazsoo Correction; Initially ALL imports were replaced by inline:ing. However, on second thought, it was deemed a bit risky, since it would affect non-pojo classes. Hence, it was reverted, and...
@Picazsoo My philosophy was: - Minimal changes. - Allow use of custom `Locale`-classes again. - Only inline/FQN when absolutely necessary. This way, the original PR is kept as-was as much...
Yes, my bad @ahoehma. This was due to rebasing this branch, without re-building and generating the updated sample files. Will update 👍
Hi @ahoehma ! This is something I identified also, see #22313 .
@ahoehma is this the failing assertion? ```java JavaFileAssert.assertThat(files.get("Locale.java")).isNormalClass() .hasNoImports("java.util.Locale"); ``` Because if it is, then it is the added import in 7.15.0 - 7.16.0 that is causing this to fail.
I've assessed this, and I would say that the keys should not be of type `K`. The reason, is that there is ambiguity whether all keys should of the same...