Charlie Le
Charlie Le
Hi @friedrichg, just wondering if you're still working on this. I'd like to help out if possible.
All components should typically have the same flags and values be set. Perhaps the only time they should be different is if there's availability zone awareness enabled and you want...
Yes, they are valid for all components.
Logs from TestRing_ShuffleShardWithLookback_CorrectnessWithFuzzy have expired. Do we still see it occurring?
> @friedrichg should i remove the field from the config struct itself? > > https://github.com/cortexproject/cortex/blob/057313a8d4d26702ed6252468e71a0abfa96ab8b/pkg/distributor/distributor.go#L141 If this is removed, wouldn't this cause problems for config files that still reference this...
> > > @friedrichg should i remove the field from the config struct itself? > > > > https://github.com/cortexproject/cortex/blob/057313a8d4d26702ed6252468e71a0abfa96ab8b/pkg/distributor/distributor.go#L141 > > > > > > If this is removed, wouldn't...
Hello @SungJin1212, thank you for opening this PR. There is a release in progress. As such, please rebase your CHANGELOG entry on top of the master branch and move the...
> If we were to support the ScrapeConfig CRD (this issue: https://github.com/open-telemetry/opentelemetry-operator/pull/3103) would that combination be sufficient to solve the underlying issue here? Yeah, I think using the ScrapeConfig CRD...
The ScrapeConfig CR should be able to do this now.
Example retry: https://github.com/cortexproject/cortex/actions/runs/9196226564/job/25293837536?pr=5968 ``` for run in $(seq 1 3); do make BUILD_IN_CONTAINER=false test && break echo "Retrying tests... Run $run failed." done shell: sh -e {0} go test -tags...