Charlie Lin
Charlie Lin
> > I don't know how to make a test that would hit this case > > Is it possible to make a unit-test for the pass itself ? Test...
~Issue is with `find_reduce_reduce` matcher. Sometimes it gives the mentioned error, sometime it's a seg fault.~ Investigating what is the cause of the issue. Error is actually in gpu::compile_ops. Something...
#3039 does get around the `packed_or_broadcasted` error. Now has a seg. fault in `gpu::compile_ops`
#3070 fixes the seg fault
> If you want to see the order of operators, you can inspect the submodules before compile_ops is called. This is a better option than trying to encode the graph...
Need to install rocm-llvm-dev to have it, need to update the READMEs
What's the status of this PR? Should anything be reviewed at this stage or a meeting held?
Old API, have the new op builder PRs.
> > Code changes look fine, should have ONNX parse tests to verify what it does. > > There are tests being added to another PR, along with int4 type...