Chenyu Yang comments

Results 11 comments of


                                            Chenyu Yang

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

> The former implementation had it's reason as well as the internal toString method is mostly not ideal. The main problem is that `hasBuiltInToString` does not know about the toPrimitive...

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

@BridgeAR Thank you for the reminder. I have modified the implementation and passed all the tests with 'make test'.

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

@legendecas PTAL

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

@legendecas Thank you, I've made the changes according to your suggestions. Could you please take a look?

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

@BridgeAR Would you mind reviewing it again?

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

Thank you, @BridgeAR . I'll see how to solve it

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

@BridgeAR I've solved all the linter error. Could you please add the 'request-ci' tag again?

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

Thanks! @BridgeAR I resolved the merge conflicts and it should look ok now.

detect Meteor Lake CPU model

Tested using Intel SDE for MTL/RPL/ADL: ``` #!/bin/bash bash scripts/local-build.sh SDE_BIN="path/to/sde" # Don't use -mtl/rpl/adl option of SDE, the cpuid returned in that is wrong. Below is the cpuid content...

detect Meteor Lake CPU model

Thanks for reviewing the PR, could you help have a look again? @fbarchard