Catherine Flores comments

Results 62 comments of


                                            Catherine Flores

unnecessary call to min function

This is a good idea. You'll want to match on an `Expr` method call, the receiver is the `0` and the argument is the `42_usize`. It'd be easiest to just...

unnecessary call to min function

> I think i don't quite understand what you're saying. It's 4am. On the first section I mean that, rather than only linting when the receiver is `T::MIN`, we always...

unnecessary call to min function

> My bad. Was just explaining why it was worded improperly 😅 You're fine :)

Suggest `.cast()` instead of `as` for pointer casts

> Does ptr_as_ptr support the new `cast_{mut,ref}`? This is now covered by `ptr_cast_constness`.

Suggest removing `filter_map` for `Iterator::filter_map(|x| Some(x))`

PS - The original idea was for removing the `Some` instead of changig `filter_map` -> `map` if it's `Option` (including references), but this is a good addition too :3

Suggest removing `filter_map` for `Iterator::filter_map(|x| Some(x))`

It isn't machine applicable, yes

False "missing_const_in_fn" for a function that consumes `self`

I believe this was already fixed in #10891. https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=7c430738d1e182a7bbb03c1ba398d1da

module_name_repetitions false positive when in private module

This was fixed for `module_inception` in #10917. The relevant change is: https://github.com/rust-lang/rust-clippy/blob/c55669513af7e0afaf65bd9b150fd827dc4446c2/clippy_lints/src/enum_variants.rs#L262C53-L262C53 We can move this to the outer `if` expression and rename the configuration option and it should all...

Add `missing_transmute_annotations` lint

There's also #11047 for basically an identical lint, it's inactive though

Add `missing_transmute_annotations` lint

I didn't bring up anything, though I don't think it's worth it to block on anything. It was mostly supposed to be about allowing some edge cases (like closures) which...