George Tattersall
George Tattersall
Following on from the conversation [here](https://github.com/frerich/clcache/issues/357#issuecomment-521528069) I would say the cl.exe version would be the best way to grab the toolset version using the mapping [here](https://devblogs.microsoft.com/cppblog/side-by-side-minor-version-msvc-toolsets-in-visual-studio-2017/). From what I can...
@izmmisha Any suggestions for codecov? I'm not too familiar with it tbh.
> @Cascades lines 1758-1763 can be covered by unit tests > lines 160,164 require to change initialization order of coverity and clcache modules (clcache.pth) > lines 132-135 can be covered...
@izmmisha we think this about done then? :)
@izmmisha I am tresting it now.. so with these changes I wont need `TrackFileAccess = false` anymore and I should see that after hitting build a second time, CMake will...
@izmmisha Yes! I did remove that too.. currently building so I'll get back to you
@izmmisha @frerich Yes! This works a dream!! My output on VS2019 with CMake is now it saying it doesn't need to update anything because it's already been built, as expected.
@frerich sorry to bother, but these changes are incredibly useful for MSBuild users, our build times upon second build go from 3 mins with clcache to 2 secs (which is...
@izmmisha Thought it would be a pain to do it with a rebase, so have force pushed the changes to bring it up to date, but with a commit on...
@izmmisha Cool, thanks. Codecov failed but I may try and fix that today if I have time... Is the logic of your changes done or do you have more work?