Carl

Samples: Current implementations of CopyBitstream2 might create issue in CH264FrameReader

1

The file sample_utils.cpp defines a function CopyBitstream2 that is wrongly implemented. This method is used by the CH264FrameReader class and consumed in decoding pipeline. First of all, is not clear...

Sample_encode: CEncodingPipeline::m_pUserModule useless

2

In the sample sample_encode, the class CEncodingPipeline declares a member m_pUserModule. However, it is not consumed and the memory is not freed in the Close method.

Hi, I think that I discovered a logic issue in methods: 1. CBuffering::SyncFrameSurfaces() 2. CBuffering::SyncVppFrameSurfaces() Since the both methods follow a similar pattern, I will explain it only for one....

Hi, I think that I have detected thread concurrency issue in the following method provided by sample_common: 1. BaseFrameAllocator::AllocFrames 2. BaseFrameAllocator::ReallocFrame These methods do not acquire a lock on mutex...

The published nuget package does not contain license information. Third Party software compliance tool like BlackDuck trigger unknown license warning.