Results 31 comments of Cal Leung

Let's clear the conflicts

> Can you explain the issue that it fixes or point to a GH issue? Updated description to describe behavior - https://github.com/MetaMask/metamask-mobile/pull/8495#issue-2111759721 Issue is connected to ticket - https://github.com/MetaMask/mobile-planning/issues/1552

Will be resolved by https://github.com/MetaMask/mobile-planning/issues/1618

> ## [![Quality Gate Failed](https://camo.githubusercontent.com/5333b8e2ff49bd5efdc6d2efd30ec08d7ac8d67c5e80190d03b6c2cb29a5de8b/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d6661696c65642d323070782e706e67)](https://sonarcloud.io/dashboard?id=metamask-mobile&pullRequest=9568) **Quality Gate failed** > Failed conditions ![](https://camo.githubusercontent.com/ee78c91cde137cf4668f72b8e1247dadaaeb117c99c74bed0f21b1681b517491/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6661696c65642d313670782e706e67) [23.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=metamask-mobile&pullRequest=9568&metric=new_coverage&view=list) (required ≥ 40%) > > [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=metamask-mobile&pullRequest=9568) Let's increase test...

E2E regression pipeline run here - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f910275e-247c-4c42-b6a6-fa975d4f74f7

Latest commit just removes unused imports. Commit before that passes both smoke and regression PR ✌️

Regarding PR description - I can see in current prod that the notification button is behind a feature flag. Does this mean that users shouldn't be able to interact with...

Approved from code perspective, will defer to @Jonathansoufer regarding QA

@shanejonas nice work on this! Just curious, were you ever able to get the mock server working?

Fixed in https://github.com/MetaMask/metamask-mobile/pull/12740